-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge forward private 3.x #64
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding .gitignore * re-ordering items * fix typos
[ch58083] add close [ch58076] make connection timeout configuration [ch58072] add offline mode [ch58435] make event sending configurable
Linting and some refactoring of streaming code.
A user submitted contribution was merged to support Aeson 2.0. While all of our tests were passing, this was because we lacked a test environment that actually used 2.0 This commit addresses the remaining compatibility changes and introduces a later test environment to ensure we are actually building with Aeson 2.0 support.
A customer recently provided two pull requests -- one to add the generated cabal file to our repository and the second to update our hlint configuration file. While great, these change aren't sufficient because - We have no way to enforce the generated cabal file is up to date - We aren't running hlint during the CI process This commit introduces CI behaviors to resolve both of these issues.
In a previous commit I updated the releaser config. However, I failed to adjust two additional bits of configuration. - The repository now includes a cabal file which contains version information. We will now update that. - docs need to be copied into the appropriate releaser directory for the GH pages branch to be updated correctly.
The OSX builds have been taking a very long time, despite doing less work than the Linux equivalents. A little digging has uncovered incorrect CI caching for the OSX builds. This small change has taken the build from approximately 45m to 9m per OSX run.
A customer contributed this fix. I made some minor tweaks, but testing seems to indicate everything works as expected. Co-authored-by: Veronika Romashkina <vrom911@gmail.com>
When we bumped the version numbers for the v3 release, we didn't bump the corresponding versions in the redis store. We didn't catch this because we don't try to build the redis package in CI, and we certainly don't try to build it against every supported Stackage resolver. For now, I've taken the simplest solution to get some tests confirming the behavior. Once I merge this forward in the v4 branch, I will look at simplifying a lot of the redundancy that exists in our unit tests.
I actually don't think we want this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.